Static-to-static links issues (e.g. broken image on 503 page)
Closed this issue · 1 comments
On https://static.google.codecity.world/503.html, the link to the image is broken because it goes to /static/logo-error.svg, which is interpreted by the browser as https://static.google.codecity.world/static/logo-error.svg which does not exist.
Changing the src= link to logo-error.svg works fine when the error page is being served as https://static.google.codecity.world/503.html, but breaks single-domain configs where it will usually be served on the requesting (failing) URL rather than the error triggering a 302 redirect to the error page.
This raises a somewhat broader question: in-database we can use $.servers.http.makeUrl to create URLs for static resources, but how do we want to handle links to static resources from other static resources?
Proposed (and implemented) fix: just symlink static/static/ to ., so that requests for static.example.codecity.world/static/… will work. I guess this allows /static/static/static/static/… to be a valid URL, but I can't really think of any way this could cause an actual problem.