refactor - Move Search Logic from Search.execute() to FhirEngine.search()
itstanany opened this issue · 2 comments
itstanany commented
Describe the Issue
- For Improving separation of concerns and single responsibility, I see search logic should be moved from Saerch.execute extension function to the fhir engine search method
Would you like to work on the issue?
Y
jingtang10 commented
thanks for raising this - i actually think it might be cleaner to move the whole thing to the search pacakge... i see a future where the data access (CRUD), search, and sync APIs live in different packages.
can you see how that'll look like?
jingtang10 commented
I commented here: #2541 (comment)
the search
and count
apis are defined in the
com.google.android.fhir
package. I think it might make more sense for them to be moved to thecom.google.android.fhir.search
package