google/blockly

In rc/v11.0.0 you can't redo drag changes that disable blocks

johnnesky opened this issue · 1 comments

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

The controls_flow_statements and the procedures_ifreturn blocks are automatically disabled if they are dragged outside of any loop or procedure definition, respectively. In the rc/v11.0.0 branch, such a drag change can be undone, but not redone. In fact, if such a change is performed, all previous changes in the undo history cannot be redone.

Drag changes that enable blocks seem to be fine. Only drag changes that disable blocks cause the bug.

Reproduction steps

  1. Check out the rc/v11.0.0 branch.
  2. Run npm run start to view the playground.
  3. Drag a controls_flow_statements block into the workspace. It will be disabled.
  4. Drag a controls_repeat_ext block into the workspace separately.
  5. Drag the controls_flow_statements block into the controls_repeat_ext block as a child. It will become enabled (At this point, the changes so far are undoable and redoable.)
  6. Drag the controls_flow_statements block back out of the controls_repeat_ext block. It will become disabled again.
  7. Undo.
  8. Attempt to redo. It won't work.
  9. You can undo a few more steps but you won't be able to redo them.

Stack trace

No response

Screenshots

No response

Browsers

Chrome desktop

See also: #7958