google/chartjs.dart

Add 'external' modifier to JS interop classes to support Dart 2.8.1

Closed this issue · 3 comments

BenEstremera commented

When using chartjs with Dart 2.8.1, I get the an error requesting the use of the 'external' keyword for the fake constructors on lines 28 and 85 of chartjs.dart

Error compiling dartdevc module:chartjs|lib/chartjs.ddc.js

packages/chartjs/chartjs.dart:28:3: Error: JS interop classes do not support non-external constructors.
Try annotating with external.
  Chart.fakeConstructor$();
  
Try annotating with external.
  PluginServiceStatic.fakeConstructor$();
  (line 85)
treeplate commented

c5d7988 gets rid of those constructors,

treeplate commented

so this should be closed

kevmoo commented

👍