google/closure-compiler-js

Gulp: doesn't work with empty streams

fabiospampinato opened this issue · 6 comments

If the stream is empty, i.e. doesn't contain any files, after running this plugin I have one file named compiled.js in the stream with this as content: 'use strict';

This plugin shouldn't add any files to an empty stream.

We're going to be combining the JS version into the same deployment as the java version. The gulp plugin for the java version already covers this case properly.

@ChadKillingsworth great! I'll close this as soon as there's a version of google-closure-compiler-js pushed to NPM that fixes this, which I don't think it's the case atm, right?

Correct - but I wish to point out that you'll be switching packages. There will only be a google-closure-compiler.

All right, I'll just switch to google-closure-compiler then, thank you.

It was published today.