etags break the instance validator

Question

bsimmons-onboard opened this issue 2 years ago · 4 comments

Describe the bug
The instance validator doesn't work on entities that include etags.

To Reproduce
minimal.yaml
6a99999c-05c8-4a01-8c4a-99f256be4c7f:
code: Test-Building
etag: d7b7777e
type: FACILITIES/BUILDING

python instance_validator.py -i minimal.yaml

while parsing a mapping unexpected key not in schema 'etag' in "<unicode string>", line 3, column 1: etag: d7b7777e ^ (line: 3)

OS:
Ubuntu

Answer 1 · 2023-04-05T22:20:32.000Z

This has to do with a conflict between the CONFIG_METADATA operation and the existence of etags. Looking into it.

Answer 2 · 2023-04-10T16:06:59.000Z

@trav3711 @bsimmons-onboard you need to update the this part:

CONFIG_METADATA:
  operation: UPDATE

Answer 3 · 2023-04-11T20:43:35.000Z

@charbull, I can confirm that adding the UPDATE operation allowed me to run the instance_validator on an building_config with etags.

Answer 4 · 2023-04-11T20:56:54.000Z

cool, thank you for confirming. closing for now, feel free to reopen if needed.