Mocha as a `dependency`

Question

Mocha as a `dependency`

nucliweb opened this issue 2 years ago · 3 comments

nucliweb commented 2 years ago

Hello,

I see that the mocha package is as a dependency and I think that is a devDependency, right?

Answer 1 · 2022-03-15T16:20:58.000Z

This template does run the tests after every build to ensure the build is good.

Answer 2 · 2022-03-15T17:33:43.000Z

Ok, but the tests run in dev or deploy mode. We don't need mocha in the production bundle, so if we move as a devDependency the mocha is available to run in build time because is installed too in the install process.

I know, if we don't import mocha in the code, mocha isn't part of the bundle but is a best practice to add as a dependencies only the packages needed to use in production or if the package is a tool or library.

Answer 3 · 2022-03-15T17:37:02.000Z

Nothing from package.json is currently bundled. I see the case of moving 100% of deps into devDepencencies. Feel free to send a PR.