bad documentation: missing selector
jonbcampos opened this issue · 1 comments
jonbcampos commented
Describe the bug
The documentation to install knative-gcp seems wrong. There is an example to pull a selector messaging.cloud.google.com/crd-install=true
, this doesn't exist in cloud-run-events.yaml
.
kubectl apply \
--selector messaging.cloud.google.com/crd-install=true \
-f https://github.com/google/knative-gcp/releases/download/v0.15.0/cloud-run-events.yaml
Expected behavior
This line should either be removed or cloud-run-events.yaml
should be updated to include the proper selector.
To Reproduce
Run the install steps, specifically:
kubectl apply \
--selector messaging.cloud.google.com/crd-install=true \
-f https://github.com/google/knative-gcp/releases/download/v0.15.0/cloud-run-events.yaml
Knative-GCP release version
0.19.0 and 0.15.0
Is this selector and its resources important?
jonbcampos commented
when you run the command, you get error: no objects passed to apply