google/ndash

End of steam never reached on dash stream with no closed caption

angelo-p opened this issue · 2 comments

angelo-p commented

Hello there.
I am testing the ndash library under ubuntu 16.04 64bits.
When playing a dash stream with no closed caption, the EOS is never reported.

randyrossi commented

Just to clarify, you're saying the ndash_is_eos() call never returns true? I just tried it with a test stream and it does flip to true in my case. (Our sample player currently ignores it.) Can you provide a sample stream?

angelo-p commented

Hi Randy,
Thanks for looking into this.

Sure, here is the test stream In am using:
http://yt-dash-mse-test.commondatastorage.googleapis.com/media/car-20120827-manifest.mpd

the stream has no closed-caption track. the ndash_is_eos() always return false.
A bit of debugging from my side shows that:

  • in the DashThread::OnManifestRefreshed() function , a DASH_FRAME_TYPE_CC track_ is created with a is_eos_ bool field set to false.

  • in the CopyFrameImpl, the FillTrackSampleHolders() function never return false because the DASH_FRAME_TYPE_CC track_ never reaches EOF since my test stream doesn't have closed-caption.