Small bug on pixel_aspect_ratio?

[apple2373]

pixel_aspect_ratio is always one because of pixel_aspect_ratio=colmap_camera.fx / colmap_camera.fx

• see https://github.com/google/nerfies/blob/5b181d8f50fa961139f86aa31f2e05c9190aaec4/notebooks/Nerfies_Capture_Processing.ipynb

def convert_colmap_camera(colmap_camera, colmap_image):
  """Converts a pycolmap `image` to an SFM camera."""
  camera_rotation = colmap_image.R()
  camera_position = -(colmap_image.t @ camera_rotation)
  new_camera = Camera(
      orientation=camera_rotation,
      position=camera_position,
      focal_length=colmap_camera.fx,
      pixel_aspect_ratio=colmap_camera.fx / colmap_camera.fx,
      principal_point=np.array([colmap_camera.cx, colmap_camera.cy]),
      radial_distortion=np.array([colmap_camera.k1, colmap_camera.k2, 0.0]),
      tangential_distortion=np.array([colmap_camera.p1, colmap_camera.p2]),
      skew=0.0,
      image_size=np.array([colmap_camera.width, colmap_camera.height])
  )
  return new_camera

Strictly, it should be pixel_aspect_ratio=colmap_camera.fy / colmap_camera.fx