google/pkcs11test

Clarification related to InitToken Tests

praveenkmurthy opened this issue · 1 comments

In slot.cc, TEST_F(PKCS11Test, TokenInit),

After C_InitToken() call with g_so_pin , there is a comment which says "both the pins would have been reset. we need to set them back". But as per PKCS#11 v2.40 doc, it says the value of SO Pin at the end of C_InitToken() call shall be that of pPin which is passed as an argument to the call. In our case it will be g_so_pin and NOT g_reset_so_pin.

Good spot, thanks.

(Aside: I mostly wrote this for working with Chaps, which has its own way of dealing with users and so doesn't support InitToken/SO login.)