google/riegeli

Build failure with C++17 w/ Clang

blais opened this issue · 1 comments

blais commented
Use --sandbox_debug to see verbose messages from the sandbox
In file included from external/com_google_riegeli/riegeli/chunk_encoding/chunk.cc:15:
In file included from external/com_google_riegeli/riegeli/chunk_encoding/chunk.h:23:
external/com_google_riegeli/riegeli/base/base.h:607:1: error: no template named 'type_identity_t' in namespace 'riegeli'; did you mean 'internal::type_identity_t'?
RIEGELI_INTERNAL_INLINE_CONSTEXPR(size_t, kDefaultBufferSize, size_t{64} << 10);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:287:20: note: expanded from macro 'RIEGELI_INTERNAL_INLINE_CONSTEXPR'
  inline constexpr ::riegeli::type_identity_t<type> name = init
                   ^~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:276:1: note: 'internal::type_identity_t' declared here
using type_identity_t = typename type_identity<T>::type;
^
external/com_google_riegeli/riegeli/base/base.h:610:1: error: no template named 'type_identity_t' in namespace 'riegeli'; did you mean 'internal::type_identity_t'?
RIEGELI_INTERNAL_INLINE_CONSTEXPR(size_t, kMinBufferSize, 256);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:287:20: note: expanded from macro 'RIEGELI_INTERNAL_INLINE_CONSTEXPR'
  inline constexpr ::riegeli::type_identity_t<type> name = init
                   ^~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:276:1: note: 'internal::type_identity_t' declared here
using type_identity_t = typename type_identity<T>::type;
^
external/com_google_riegeli/riegeli/base/base.h:611:1: error: no template named 'type_identity_t' in namespace 'riegeli'; did you mean 'internal::type_identity_t'?
RIEGELI_INTERNAL_INLINE_CONSTEXPR(size_t, kMaxBufferSize, size_t{64} << 10);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:287:20: note: expanded from macro 'RIEGELI_INTERNAL_INLINE_CONSTEXPR'
  inline constexpr ::riegeli::type_identity_t<type> name = init
                   ^~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:276:1: note: 'internal::type_identity_t' declared here
using type_identity_t = typename type_identity<T>::type;
^
external/com_google_riegeli/riegeli/base/base.h:619:1: error: no template named 'type_identity_t' in namespace 'riegeli'; did you mean 'internal::type_identity_t'?
RIEGELI_INTERNAL_INLINE_CONSTEXPR(size_t, kMaxBytesToCopy, 255);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:287:20: note: expanded from macro 'RIEGELI_INTERNAL_INLINE_CONSTEXPR'
  inline constexpr ::riegeli::type_identity_t<type> name = init
                   ^~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:276:1: note: 'internal::type_identity_t' declared here
using type_identity_t = typename type_identity<T>::type;
^
In file included from external/com_google_riegeli/riegeli/chunk_encoding/chunk.cc:15:
In file included from external/com_google_riegeli/riegeli/chunk_encoding/chunk.h:29:
external/com_google_riegeli/riegeli/chunk_encoding/constants.h:43:1: error: no template named 'type_identity_t' in namespace 'riegeli'; did you mean 'internal::type_identity_t'?
RIEGELI_INTERNAL_INLINE_CONSTEXPR(uint64_t, kMaxNumRecords,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:287:20: note: expanded from macro 'RIEGELI_INTERNAL_INLINE_CONSTEXPR'
  inline constexpr ::riegeli::type_identity_t<type> name = init
                   ^~~~~~~~~~~
external/com_google_riegeli/riegeli/base/base.h:276:1: note: 'internal::type_identity_t' declared here
using type_identity_t = typename type_identity<T>::type;
^
5 errors generated.
Target //experiments/v3/protos:export_as_protos failed to build
Use --verbose_failures to see the command lines of failed build steps.

I haven't looked into the details yet.
C++14 w/ Clang also fails to build (differently), as well as C++17 w/ gcc.

blais commented

Thank you!