google/secrets-gradle-plugin

Remove misleading double quotes in local.defaults.properties file

antonsurya opened this issue · 2 comments

antonsurya commented

The local.defaults.properties file contains the following:

MAPS_API_KEY=""

I copied that line and added the following line in my local.properties:

MAPS_API_KEY="AIzaalskro0jlskdj2kr5jlksbjlksdjflkse0p"

where the AIza... is a valid API key.

With this configuration, when you run your app you will get an authentication error, because the whole string including the double quotes is $MAPS_API_KEY.

Please consider to remove the double quotes in local.defaults.properties because it may mislead people.

antonsurya commented

Hum, the comment above is actually for a sibling repo: https://github.com/googlemaps/android-samples/blob/main/ApiDemos/kotlin/local.defaults.properties, which uses this secrets Gradle plugin, but I think it would be good to address the issue also here. Let me know if you want me file an issue on the repo as well.

arriolac commented

Thanks for catching that! Will address this. Feel free to also send a PR