google/sqlcommenter

feat(support) TypeORM

feihan opened this issue · 5 comments

feihan commented

Hi,

this is a great library.
Unfortunately we are mostly using Typeorm (https://typeorm.io/) which is not supported yet.
I think this is one of the most important node.js ORMs currently.

If anyone is interested, i can try to help out as much as i can.

Thanks

balachandr commented

@feihan , we will be happy to work with you on getting Typeorm done. Let us know if you would like to contribute.

feihan commented

@balachandr yes i would love to contribute.
Unfortunately i have very little knowledge about sqlcommenter yet.

pankyriazo commented

Hello, i would be happy to work on supporting TypeORM. Are there any additional guidelines besides the existing code?

ninapavlich commented

Hello! I would like to +1 this request!

clintonb commented

You can see the early history TypeORM comment support at typeorm/typeorm#3643. In order to support sqlcommenter—even manually adding comments—TypeORM will need to be updated to affix comments to the end of the query instead of prefixing to the beginning.

After further testing I have determined that prefixed comments show up in the Cloud SQL tool as well as Datadog. My sampling rate was too low.