google/zoekt

built-in pages should support '/' shortcut to go to search box.

hanwen opened this issue · 4 comments

hanwen commented
built-in pages should support '/' shortcut to go to search box.
dziemba commented

Hey @hanwen, I saw that you implemented this in 983e877

It's a cool feature! Unfortunately it breaks entering the / character in the search box. That's because the event handler catches all key presses for that character, even when entering text into the text field, and then stops the event chain.

I have not tried this, but maybe it's already enough to remove the return false in the handler function, so that the event keeps propagating.

hanwen commented

that kind of works, but then it puts '/' in the search box too . I guess I have to 'return false' only if search box is not in focus.

  • 👍1
dziemba commented

Looks good, thanks! 👍