Get beta version of this client library to stable.
vtsao opened this issue · 46 comments
Hey @vtsao, we have started to revise classes in this regard : https://github.com/theodo/adwords
I agree on PSR-0. Note also that PSR-4 has now been approved as well: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md
👍 Some PSR-0/PSR-4 love please!
That would be awesome, I'm deploying apps with php 5.5, and going back to use code w/o namespaces or compatible with 5.2 is a no no, Even php officially dx http://php.net/eol.php, 5.2 three years ago.
We should push towards PSR-0/1/2 at least and re-organize classes with their proper namespaces.
Maybe start a new repo and leave this as legacy code.
hey guys, have you all checked out the experimental branch w/ full namespace support?
Hey @saturnism, I did and I was pretty impressed by the good job. However, I had the feeling it was not totally compliant with latest autoloading standards (but I may be wrong about the latter):
ping @davinov
Thanks, we are still working on the experimental branch and deciding the path we want to take moving forward with it.
@vtsao Thank you for the update, are these decision opened to discussion?
Plus one on the namespaces. Without them, it's just a mess.
With PHP 5.2 being deprecated, there's no reason not to implement namespaces, to play nice with PSR-4.
Any word on this (at the least an update of the experimental branch to work with the current API)? I believe Jan 1 was the official we-don't-support PHP 5.2 date was it not?
We are still planning to work on it, but no updates as of this moment.
Why haven't there been any commits to experimental branch since august 2014? PSR-0 compliance these days is a must not something you can just ignore.
Just drop PHP 5.2 support already. It's been more than 4 years since 5.2.17 was released.
PSR-0 is deprecated is it not?
Yeah, I can see now that it is. PSR-4 now replaces it.
We've only recently announced that we're dropping PHP 5.2 support this Jan (many developers are still on 5.2 so it's hard to just stop supporting 5.2).
So, we are looking forward to revamping this client library this year. Stay tuned!
👍
Yes, it's still on our radar.
I would recommend just using the non-experimental version for now. I hope to get around to making some updates to this this quarter.
@florisgoumans it is not true that this library is "un-usable" in modern day frameworks.
We use it quite extensively making thousands of api calls for hundreds of clients every day in a symfony 2 application. We install it via composer without any issues and have access to all classes using the global namespace.
It is true that being a none PSR compliant library causes several pains (chief among them is the order in which you declare your object), but you should be able to use it without the use of requires or includes.
If you wrap the client functionality in a class or set of classes, updating the code in the future (with a PSR version of the library) will be quite easy!
Good luck
@vtsao FYI I have created a small command/library that can be used to break files containing multiple classes into "single file per class", it can also add missing namespaces. Check it out: ClassyFile.
Generating the new files is as simple as :
include 'vendor/autoload.php';
$classifile = new \Onema\ClassyFile\ClassyFile();
// a namespace will be generated from the file path: `Google\Api\Ads\AdWords` and saved to the cwd under /Google/Api/Ads/AdWords/Lib/
$filePath = 'googleads/googleads-php-lib/src/Google/Api/Ads/AdWords/v201502/';
$classifile->generateClassFiles($filePath, true, 3, 4);
// a namespace will be generated from the file path: `Google\Api\Ads\AdWords\Lib` and saved to the cwd under /Google/Api/Ads/AdWords/Lib/
$filePath = 'googleads/googleads-php-lib/src/Google/Api/Ads/AdWords/Lib/';
$classifile->generateClassFiles($filePath, true, 3, 5);
// ...or from the CLI:
$ php classyfile convert googleads/googleads-php-lib/src/Google/Api/Ads/Common/Lib/ --create-namespace --offset=3 --length=5
It currently doesn't account for adding use statements if none have been specified in the original file, but I believe is a good step in the right direction.
I have added two events to allow the extension of the library. Adding missing use statements could be added in the form of an event listener or an event subscriber.
Let me know if this is helpful or if you have any questions.
@hakimio It should require it. I was testing it with different libraries... I forgot to update the composer.json 😊 . Will update.
*it should not require it
Any update on this?
I've had some more time to work on this recently, but no ETA yet.
👍 for PSR-4
I would like namespace too...
Do you finally have an ETA for this feature request?
Also when will you fix your phpdoc?
@hakimio No ETA yet. We are actually rewriting the client library, so it's not just namespacing the existing one.
+1. We're integrating this library currently and would love PSR-4 support.
FYI we have just released a new beta version of this library, please see our blog post for details:
http://googleadsdeveloper.blogspot.com/2016/02/announcing-beta-release-of-new-ads-php.html
👍 Good stuff, can't wait to have the new version officially released!
FYI we've made another release of the beta version of this client library to the experimental branch. Please check it out and see the changelog for more information.
@vtsao Excellent work! Thank you!
We've made another beta update (1.3.0-beta):
https://github.com/googleads/googleads-php-lib/tree/experimental
Check out the changelog here:
https://github.com/googleads/googleads-php-lib/blob/experimental/CHANGELOG.md
We've made another release of the beta client library (1.3.1-beta). Fixes some bugs and we've released DFP retrieval examples:
https://github.com/googleads/googleads-php-lib/tree/experimental/examples/Dfp/v201602
Check out the changelog here:
https://github.com/googleads/googleads-php-lib/blob/experimental/CHANGELOG.md
FYI we've made another release of the beta client library to the experimental branch (1.4.0-beta). Please see:
https://github.com/googleads/googleads-php-lib/blob/experimental/CHANGELOG.md#140-beta
for changes.
Hi, are there any updates when experimental branch will stop being experimantal?
Thx, looks good so far 👍
Are you planning to rename the package? 1.4 is less than 14.0...
@jbboehr Thanks for bringing this up, we're currently still thinking about how to proceed with this, will definitely let the community know when we've decided.
It appears the experimental branch now only supports a deprecated version of API, any updates on this please? Thanks.
@dan-rally we'll be updating experimental soon.
The experimental library has now been pushed to stable and the old library has been deprecated. Please see our blog post announcement for details:
https://googleadsdeveloper.blogspot.com/2016/12/announcing-new-ads-php-client-library.html
Thanks for everyone's contributions to both the old and new libraries!