googleapis/cloud-profiler-nodejs

Unit tests with Node 13?

nolanmar511 opened this issue · 4 comments

nolanmar511 commented

Right now, we run unit tests with Node 8, 10, and 12.

@bcoe, @JustinBeckwith -- Is there planned support for unit tests with Node 13?

bcoe commented

@nolanmar511 I'm open to adding 13, I think we have 3 more months until 14?, but I'd like to take care of updating the testing matrix when we drop Node 8; which I'm hopeful will be mid-way through February.

nolanmar511 commented

Node version changes are somewhat higher risk for this module, because of it's native dependency that relies on V8.

I'd like to add integration tests with Node 13, but I'd prefer to add integration tests and unit tests at the same time (for ease of debugging).

Adding just integration tests for Node 13 might be my best choice, but it is somewhat complicating. Our integration test is currently written with the assumption that https://github.com/google/pprof-nodejs has prebuilt binaries for the tested Node version. We use the same trampoline images that are used here in https://github.com/google/pprof-nodejs, and I'm not excited about releasing a pre-built binary for Node 13 when we don't have unit tests for with pprof-nodejs.

nolanmar511 commented

Yep!
I'll close this; it's resolved.