Support @grpc/grpc-js
yoitsro opened this issue · 2 comments
Is your feature request related to a problem? Please describe.
When using the C based implementation of gRPC in node, traces were being correctly reported. They no longer are with the javascript based version. This could potentially be a bug, but it more accurately seems like a new implementation is required, hence why this is being filed as a feature request.
Describe the solution you'd like
Ideally, I would enable traces with the exact same usage as is currently the case with the C based library.
Describe alternatives you've considered
Whilst there are alternatives, I haven't seriously considered implementing them due to the fact that cloud-trace-nodejs gave us everything we needed so it would make sense to modify this library to work with @grpc/grpc-js.
Additional context
N/A.
I thought it's also worth noting that since the C based version of grpc for Node is now deprecated, this feels like it should be relatively high priority (from a developer experience perspective).
Hi yoitsro,
This library is stabilized, and it's unlikely we'll add any new features like this. We recommend checking out OpenTelemetry, and seeing if its JS library has the features you need yet: https://github.com/open-telemetry/opentelemetry-js
If OpenTelemetry doesn't support your use cases, please file bugs against that library and watch that, as we'd like to get that library to the same feature set as this one, and start recommending that over this.