googleapis/google-api-ruby-client

Google::Apis::Core::BaseService#root_url documented as an Addressable::URI, now treated as String

Closed this issue · 3 comments

As of #17131, Google::Apis::Core::BaseService#root_url is being treated as a String though it is still documented as an Addressable::URI.

Environment details

  • OS: macos 14.3
  • Ruby version: 3.3.0
  • Gem name and version: google-apis-core-0.13.0

Steps to reproduce

  1. Set Google::Apis::Core::BaseService#root_url to an Addressable::URI.

Code example

s = Google::Apis::AndroidpublisherV3::AndroidPublisherService.new.tap
s.root_url = Addressable::URI.parse('http://google.com')

Output:

google-apis-core-0.13.0/lib/google/apis/core/base_service.rb:131:in `root_url=': undefined method `include?' for an instance of Addressable::URI (NoMethodError)

          if url_or_template.include? ENDPOINT_SUBSTITUTION
                            ^^^^^^^^^

Proposed fix: #17895

Thanks for catching this! I added a request to your PR.

Fixed

Thank you.