googleapis/google-cloud-php

Clean up new system tests

bshaffer opened this issue · 0 comments

bshaffer commented

PR #7695 introduced system tests as part of our workflow, but there's still a lot of work to be done.

  • As mentioned in #7695 (comment), we should keep all ENV vars in one place and define them as constants
  • Remove tests/System/bootstrap.php files if possible, or consolidate them to use one in Core
  • Cleanup use of PROJECT_ID environment variable, in favor of GOOGLE_PROJECT_ID, GOOGLE_CLOUD_PROJECT, or remove it all together
  • Cleanup use of TestHelpers to make all tests consistent.