Chore: remove direct dependency on google-cloud-shared-config

Question

Chore: remove direct dependency on google-cloud-shared-config

Closed this issue 3 months ago · 3 comments

Regarding this #1550
remove this direct dependency so that this repo only needs sdk-platform-java-config dependency.

Answer 1 · 2024-03-20T23:49:59.000Z

Hi @zhumin8, a couple of quick questions. Should this be part of the current release cycle? Why is google-cloud-shared-config unnecessary compared to sdk-platform-java-config?

Answer 2 · 2024-06-10T21:19:36.000Z

Hi @zhumin8, I am also wondering the reason for removing this direct dependency. Could you help us understand why it is unnecessary and it is safe to remove google-cloud-shared-config?

Answer 3 · 2024-09-05T14:24:57.000Z

@cindy-peng sorry for the delay, this message fall through the cracks and I just noticed it.

So sdk-platform-java-config consolidates configs from google-cloud-shared-config and hosts the google-cloud-shared-dependencies version under the google-cloud-shared-dependencies.version property.
That said, this issue is obsolete as I see #1679 recently made the change.