googleapis/nodejs-vision

Missing `types` in `package.json`

marcushultman opened this issue · 3 comments

marcushultman commented

Environment details

  • OS: N/A
  • Node.js version: N/A
  • npm version: N/A
  • @google-cloud/vision version: 2.4.1

Steps to reproduce

  1. Inspect package.json

Description

The package contains build/src/index.d.ts next to the main entrypoint (build/src/index.js). While some TypeScript environments can interpret this correctly without a types/typings-field in the `package.json, the TypeScript Handbook says it's "advisable to do so".

galz10 commented

@marcushultman i'm not seeing index.d.ts in our repo, can you point me to this file .

marcushultman commented

@galz10 It should be generated in the build/ directory after running compile.

galz10 commented

Fixing #977