googleapis/signet

Support for Faraday 2.0.0

Closed this issue · 2 comments

dentarg commented

Faraday 2.0.0 was just released: https://github.com/lostisland/faraday/releases/tag/v2.0.0

It would be great to be able to use it with signet.

signet/signet.gemspec

Line 23 in 411f544

gem.add_runtime_dependency "faraday", ">= 0.17.3", "< 2.0"

renchap commented

As an alternative to upgrading to Faraday 2, please consider dropping the dependency on Faraday, as it often results in conflicts with other gems or apps that use Faraday and major version bumps might be hard to manage.

  • 👍1
oshow commented

I agree with reducing the dependencies. But Faraday 2.0 is an update related to middleware and adapters. signet uses neither faraday middleware nor adapters, so I think signet can loose the Faraday's version to 2.0 without doing anything.