String comparisons in MainActivity.java (and possibly elsewhere)
Closed this issue · 2 comments
himattm commented
The string comparisons in MyActivity.java are done using != rather than comparing the objects. I am under the belief that this can lead to unstable behavior. Since these comparisons are against the empty string comparisons can be easily switched to .length() or .equals(). Both of which should be more consistent.
silvolu commented
@matthewcmckenna thanks for your feedback! If you have time to submit a pull request, that would be great, otherwise I'll fix it as soon as I can.