googlearchive/git-rv

OAuth flow results in UnicodeEncodeError

Closed this issue · 1 comments

{{{
$ git rv submit
Checking out origin/review-9830044 at 9904b47aeb78defc1b9561064f048061a444bd32.
Adding reviewed commits.
Adding commit:
update part5-templates branch to match documentation https://developers.google.com/appengine/docs/p…

Reviewed in https://codereview.appspot.com/9830044/
Replacing review branch 'part5-templates' with newly committed content.
Your browser has been opened to visit:

https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

--no_oauth2_webbrowser

Created new window in existing browser session.
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "main.py", line 28, in
File "main.py", line 23, in main
File "submit.py", line 123, in callback
File "submit.py", line 99, in init
File "submit.py", line 411, in advance
File "submit.py", line 140, in verify_approval
File "submit.py", line 413, in advance
File "submit.py", line 159, in update_from_metadata
File "submit.py", line 415, in advance
File "submit.py", line 174, in create_branch
File "submit.py", line 417, in advance
File "submit.py", line 205, in commit
File "submit.py", line 419, in advance
File "submit.py", line 227, in push_commit
File "submit.py", line 423, in advance
File "submit.py", line 288, in clean_up_local
File "submit.py", line 425, in advance
File "submit.py", line 390, in clean_up_review
File "submit.py", line 340, in __add_commit_link
File "/usr/lib/python2.7/urllib.py", line 1312, in urlencode
v = quote_plus(str(v))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2026' in position 99: ordinal not in range(128)
}}

The browser URL was:

http://localhost:8001/?access_token=ya29.AHES6ZQwg3I3MFGYW7rXMqlGoUPzHcZ7lEzWUphecdgrwhxVyil4

This is actually invalid once #12 is fixed.