googlecodelabs/codelab-components

Remove custom handling of up, down, PgUp and PgDown

ddrone opened this issue · 4 comments

Right now up, down, PgUp and PgDown are bound to move to previous / next step, which is incredibly frustrating since it changes default keyboard behaviour, which is to scroll down actual contents of a step using a keyboard. More than that, it seems that there are currently no way at all to scroll contents of a step using a keyboard, which forces the user to use mouse for no good reason. Please consider removing these keybindings.

Noticed this on https://codelabs.developers.google.com/codelabs/ng2-dart/index.html, but I'm pretty sure this would apply to other codelabs as well, thus reporting the issue here.

Fixed by #29

I will need some time to propagate this to codelabs.dgc site, but it'll be there soon.

Hey @ddrone, I updated the site. How does https://codelabs.developers.google.com/codelabs/ng2-dart/ look now?

It seems one still has to click on the content to be able to scroll up and down, but it's a step forward.

Now it works much better, thanks!