[Font Bakery Dashboard] fail to create family: Bebas Neue
Closed this issue · 11 comments
GitHub PR Server can't dispatch Pull Request. ERROR Error: Signature author is required. / Don't understand what it means.
Also,"designated GitHub branch page" (link) was broken
full report
Step # 2 Create the Pull Request
finished: FAILED
Failing with reason:
Task SignOffAndDispatch FAILED
GitHub PR Server can't dispatch Pull Request.
ERROR Error: Signature author is required.
designated GitHub branch page
Step # 2 Create the Pull Request
finished: FAILED
Failing with reason:
Task SignOffAndDispatch FAILED
GitHub PR Server can't dispatch Pull Request.
ERROR Error: Signature author is required.
Thanks. It's an authorization issue.
Would it rely on designers or on us? This report went first time to designer's repository, and he asked about it. Should I ask him to do something?
Would it rely on designers or on us? This report went first time to designer's repository, and he asked about it. Should I ask him to do something?
It's interesting, I'll think about it, nothing you can do.
This report went first time to designer's repository
Yeah, nice to know it works, even though it was wrongly addressed. Is this an interface issue or why did you file it in the upstream?
Yeah, nice to know it works, even though it was wrongly addressed. Is this an interface issue or why did you file it in the upstream?
At first attempt I didn't realize there was an option to choose the destination of the Issue, so yes, I think it could be clearer with interface design.
Alright, about the "Signature author is required" message. I'm using the public email address of the login that is requesting the PR to create the commit. If the GitHub profile doesn't specify a public email, the commit will not be linked to the login. There are for sure other possibilities, but right now, I just changed the error message to a more verbose one, here for the example of @graphicoredummy:
GitHub PR Server can't dispatch Pull Request.
ERROR Error: Can't create a commit signature for name: @graphicoredummy, because there's no public email address set in the GitHub profile. If you are @graphicoredummy, please go to https://github.com/settings/profile and update the "Public email" entry. This email is used by GitHub to link the commit to your profile.
Generally, if you are using git from the command line and if it is set up properly, the email to use is probably the same as the result of calling git config --get user.email in the terminal.
Ok, I see. The need for an email makes sense. Nevertheless, when the PR is made by a third party (me in this case) the mail that would end up associated will be the one of the third party, no the designer's email. If I'm understanding well.
Would it be possible to take it directly from the designer's GitHub? In this case,
info@dharmatype.com fromhttps://github.com/dharmatype
I think it makes sense that the person who uses the tool should be the one who generates the commit, as the tool is acting on behalf of that person. It would be possible to take another email address, but it would be wrong.
Ok, if it would be taken for the commit only, it would make sense. I thought it could remain associated for any further matter on the future also.
No, it's not like that. The Dispatcher will create a commit in your name and also create the PR or Issues in your name. So that's all things you would do yourself in any way.
Yes, I meant the commit and any task associated with the uploading process.
My original doubt was if that email for the process would remain once the project was published, but is clear now that it will not.
Thanks for addressing this.