There can be two color palette layers with the same color

Question

There can be two color palette layers with the same color

Opened this issue 8 months ago · 3 comments

as seen in this example:

Using glyphs2ufo produces this output:

Bad Color Bold: Glyph A, layer color.0: Duplicate glyph layer name
Bad Color Thin: Glyph A, layer color.0: Duplicate glyph layer name

and this layer mapping (it appends a '#' to make the name unique):

<key>com.github.googlei18n.ufo2ft.colorLayerMapping</key>
      <array>
        <array>
          <string>color.0</string>
          <integer>0</integer>
        </array>
        <array>
          <string>color.1</string>
          <integer>1</integer>
        </array>
        <array>
          <string>color.0 #1</string>
          <integer>0</integer>
        </array>
      </array>

So it is not sufficient to use GSLayer.name as layer names in the ufos.

Answer 1 · 2024-05-08T01:18:43.000Z

Do you have a test font?

Answer 2 · 2024-05-08T08:29:02.000Z

https://github.com/googlefonts/glyphsLib/blob/Glyphs3-merge/tests/data/ColorComponents.glyphs

Answer 3 · 2024-05-08T13:08:02.000Z

The handling of color layers was supposed to be applied only when minimal=True (the thinking back then was that it is a ufo2ft-specefic feature so it was enabled only when minimal mode is enabled which is used when building UFOs with ufo2ft), but it seems that it is now partially applied when minimal=False:

$ glyphs2ufo ColorComponents.glyphs
Bad Color Bold: Glyph A, layer color.0: Duplicate glyph layer name
Bad Color Thin: Glyph A, layer color.0: Duplicate glyph layer name
Bad Color Thin: Glyph Aacute, layer color.0: Duplicate glyph layer name
Bad Color Bold: Glyph Aacute, layer color.0: Duplicate glyph layer name

And no warnings with:

$ glyphs2ufo --minimal ColorComponents.glyphs

I suggest we enable the handling of color layers unconditionally, since this seems to be a source of problems (e.g. googlefonts/gftools#740).