googlefonts/glyphsLib

Disabled features still interfere with automatic code

Opened this issue · 2 comments

khaledhosny commented

If a font has a disabled feature, we will still write a feature block to the UFO but with # disabled comment and all of its contents commented out. For feature with automatic code generation like kern or mark this will prevent ufo2ft from generating code for this feature. We could fix this by commenting out the whole feature block, but then going back from UFO to Glyphs will drop the feature (do we still care about this?).

anthrotype commented

going back from UFO to Glyphs will drop the feature

does ufo2glyphs un-comment the contents of these # disabled features?

We could fix this by commenting out the whole feature block

I guess we could do that only when minimal=True (fontmake sets that for compilation)

khaledhosny commented

going back from UFO to Glyphs will drop the feature

does ufo2glyphs un-comment the contents of these # disabled features?

Yes.

We could fix this by commenting out the whole feature block

I guess we could do that only when minimal=True (fontmake sets that for compilation)

Good idea.