v2.2.6 release was missing compiled code
barbeau opened this issue · 4 comments
Summary
Reported in #1008 (comment):
I took your sample code and tested it and found indeed there is something weird going on here, but it's actually a problem with the v2.2.6 build itself.
I was able to reproduce what you were seeing with v2.2.6, but not if I copied the
MapObjectManagerandMarkerManagersource code directly to my app, unmodified. I then tested v2.3.0 and this version works as expected. Using the debugger again on v2.2.6, I see that themObjectsvariable is actually aHashSetstill!For some reason, the v2.2.6 build that my PR's changes were released in does not have the change in the decompiled binary aar! It is in the source code jar though, which is even more confusing. And the change is in the v2.3.0 binary.
So v2.2.6 release didn't contain the compiled code that it should have, although v2.3.0 seems ok.
Expected behavior
All changes in main project branch should be included in releases
Observed behavior
PR's changes released in #972 (comment) does not have the change in the decompiled binary aar.
It is in the source code jar though, which is even more confusing. And the change is in the v2.3.0 binary.
I'm not certain we can update an existing published maven artifact. AFAIK, only snapshots are updatable. If this is the case, then the resolution would be to discourage usage of 2.2.6 and use the latest (2.3.0) instead. Very odd how this happened in the first place.
I checked both 2.2.5 and 2.3.0 and the changes in both these releases were in both the sources jar and binary aar of the maven artifacts. So this does seem to be isolated to the 2.2.6 release. Really odd.