googlesamples/android-dynamic-code-loading

App is crashed when it is built with serviceLoaderDebug

tsuyosh opened this issue · 0 comments

Summary

This app is crashed with the following stacktrace:

2019-05-12 00:14:54.688 19151-19151/com.google.android.samples.dynamiccodeloading E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.google.android.samples.dynamiccodeloading, PID: 19151
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.google.android.samples.dynamiccodeloading/com.google.android.samples.dynamiccodeloading.MainActivity}: java.util.NoSuchElementException
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2913)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
     Caused by: java.util.NoSuchElementException
        at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:366)
        at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:416)
        at java.util.ServiceLoader$1.next(ServiceLoader.java:494)
        at com.google.android.samples.dynamiccodeloading.MainViewModel.initializeStorageFeature(MainViewModel.kt:67)
        at com.google.android.samples.dynamiccodeloading.AbstractMainViewModel.loadCounter(AbstractMainViewModel.kt:81)
        at com.google.android.samples.dynamiccodeloading.MainActivity.onCreate(MainActivity.kt:65)
        at android.app.Activity.performCreate(Activity.java:7136)
        at android.app.Activity.performCreate(Activity.java:7127)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048) 
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78) 
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108) 
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:193) 
        at android.app.ActivityThread.main(ActivityThread.java:6669) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) 

The crashed app is built with the buildType of serviceLoaderDebug.
The crash seems to be fixed by modifying app/src/serviceLoader/java/com/google/android/samples/dynamiccodeloading/MainViewModel.kt to pass a classloader to ServiceLoader.load() like

        val serviceLoader = ServiceLoader.load(
            StorageFeature.Provider::class.java, StorageFeature.Provider::class.java.classLoader
        )