gordonklaus/ineffassign

False positive

Closed this issue · 1 comments

While scanning the Go source, this tool reports the following line as an ineffectual assignment to p:
https://github.com/golang/go/blob/35bb62e60a7779ff82c3067903b3306ff8666471/src/cmd/internal/obj/wasm/wasmobj.go#L221

Obviously, this is not the case and removing that line causes incorrect behaviour (and might even be dangerous).

Full warning:

cmd/internal/obj/wasm/wasmobj.go:225:3:warning: ineffectual assignment to p (ineffassign)

Not a false positive. Sorry.