gorgonia/tensor

Upgrade dependency "github.com/google/flatbuffers"

Closed this issue · 2 comments

Ben131-Go commented

Background

Repo github.com/gorgonia/tensor depends on github.com/google/flatbuffers@v1.12.0.

https://github.com/gorgonia/tensor/blob/master/go.mod#L11

However, comparing version v1.12.0 of github.com/google/flatbuffers from proxy.golang.org and github, there are inconsistencies.

commit time of the copy on github.com

"committer": {
      "name": "Wouter van Oortmerssen",
      "email": "aardappel@gmail.com",
      "date": "2020-03-12T22:33:39Z"
    }

commit time of the copy on proxy.golang.org

{"Version":"v1.12.0","Time":"2020-03-12T21:45:27Z"}

So the checksum from the code in github does not match the checksum saved in sum.golang.org. The v1.12.0 tag of github.com/google/flatbuffers might have been retagged after a minor edition on github. I guess you use proxy.golang.org to get dependencies, but that also shows that your project is depending on the copy of github.com/google/flatbuffers@v1.12.0 before its edition. Depending upon such inconsistent tag version may also result in some unexpected errors as well as build errors due to different proxy settings.

For example, when someone who does not use proxy.golang.org, say GOPROXY=direct, attempts to get github.com/google/flatbuffers@v1.12.0, the following error occurs.

go: downloading github.com/google/flatbuffers v1.12.0
go: github.com/google/flatbuffers@v1.12.0: verifying module: checksum mismatch
        downloaded: h1:N8EguYFm2wwdpoNcpchQY0tPs85vOJkboFb2dPxmixo=
        sum.golang.org: h1:/PtAHvnBY4Kqnx/xCQ3OIV9uYcSFGScBsWI3Oogeh6w=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

So, this is a reminder in the hope that you can get rid of this problematic version of project github.com/google/flatbuffers.

Solution

1. Bump the version of dependency github.com/google/flatbuffers

I would recommend bumping the version of github.com/google/flatbuffers to a new release, say v1.12.1, to ensure dependency copy in proxy.golang.org and github in sync.

References

chewxy commented

OK I will do this. This was already fixed in my local next-version-of-tensor-library. Sorry..

Ben131-Go commented

Thanks for your reply!