gorhill/uBlock-for-firefox-legacy

Issues with svg icons in redesigned dashboard on Gecko 45-51

Closed this issue · 3 comments

JustOff commented

There are several issues with svg icons in redesigned dashboard on Gecko 45-51:

  1. The for ( const loop need to be replaced with for ( let

uBlock-for-firefox-legacy/src/js/fa-icons.js

Line 28 in 437c899

for ( const icon of icons ) {

  1. The old Gecko versions do not support svg use href attribute, so svg icons are not visible at all

I tried to use xlink:href instead of href, but that only worked for checkboxes statically defined in settings.html and 3p-filters.html, but not for fa-icons.js-generated icons.

I believe we should still try to fix this by providing some workaround, primarily for TenFourFox.

@hawkeye116477, could you please take a look at this?

hawkeye116477 commented

Maybe polyfill would help.

JustOff commented

Well, it seems I managed to beat it with this change in fa-icons.js:

-        use.setAttribute('href', href);
+        use.setAttributeNS('http://www.w3.org/1999/xlink', 'href', href);
JustOff commented

Here is beta version to test: uBlock0_1.16.4.28b2.firefox-legacy.xpi.zip (rename zip to xpi to install).

  • 🚀1