Use of enable_super_globals()
Closed this issue · 0 comments
The third-party client library used to invoke Akismet, tijsverkoyen/Akismet uses $_SERVER
quite extensively. This is perfectly reasonable, as far as I can see, but it means I have to wrap the isSpam()
call with phpBB's $request
object's enable_super_globals()
/disable_super_globals()
, which doesn't feel that "clean", and is apparently a Bad Thing ("We would not allow something like this in our extensions database".)
On the other hand, tijsverkoyen/Akismet is by far the most popular Composer-enabled Akismet client on Packagist and seems a sensible choice, and I don't want to go forking and altering it just because enable_super_globals() doesn't seem "nice". Is there any better way? Is enable_super_globals()
that terrible? I've asked on the phpBB extension developers' forum.