gothinkster/angular-realworld-example-app

Why is there no unsubscribe in ngOnDestroy?

splincode opened this issue 6 years ago · 2 comments

splincode commented 6 years ago

angular-realworld-example-app/src/app/article/article-comment.component.ts

Line 21 in 7074a49

this.userService.currentUser.subscribe(

juristr commented 6 years ago

indeed I would add one in this component 🙂. you can submit a PR 🤓

dmytrohridin commented 6 years ago

@juristr look to PR please