gothinkster/realworld

🖥 🔧 React + Mobx

robbiedhickey opened this issue · 22 comments

robbiedhickey commented

Current Status

Todo:

  • 🏁 Fork the starter repo & post the link in this issue
  • 🎨 Create logo for repo & update issue status (@EricSimons)
  • 🔨 Implement all of Conduit's functionality per the spec & API
  • 👀 Peer review of final codebase by RealWorld admins & community (RFC)
  • 🎉 Tag v1 release, move repo to main org, and officially list it on the README!

I believe the React community would benefit from more examples of Mobx architectures juxtaposed against Redux in non-trivial applications. The only example I'm aware of is the SoundCloud Client developed by the excellent @rwieruch

I'm still getting my feet wet in the React ecosystem, but will take this on if there is not interest from a more experienced member in the community.

robbiedhickey commented

I looked into the starter kit, but it occurred to me that it might make more sense to fork the existing React + Redux example app and refactor reducers to @observable stores. Any drawbacks to this approach?

I started a fork that adds the Mobx dependencies and migrates to custom-react-scripts to enable decorator support.

EricSimons commented

@hodorswit I think your approach is perfect — no need to reinvent the React parts of the app :)

Regarding finding someone w/ more experience, @mweststrate do you know of anyone? Or perhaps someone that could provide advice to @hodorswit as he builds it out?

  • 👍1
EricSimons commented

@hodorswit I just updated the issue status + set up a Gitter room where we can handle collaborator coordination 👍

mweststrate commented

[Completely offtopic] @mosho1: Wondering about it since Friday, since I forgot to ask it, but did we meet last Friday without me realizing it? ;-) [/Completely offtopic]

mattruby commented

I'm out on this one. Yoyo exhibition tomorrow I need to prep for!

andykog commented

I love the idea, will try to allocate some time tomorrow

  • 👍1
  • ❤️1
EricSimons commented

@hodorswit wanna add @andykog to the repo & coordinate work? Feel free to use the gitter room I set up for this Mobx implementation if need be :)

srolel commented

@benjamingr @hodorswit I'll see if I have time to take a jab at it this weekend. And no, @mweststrate, sadly we did not meet :P

  • 👍1
  • ❤️1
robbiedhickey commented

Just added @mosho1 and @andykog to the repo!

  • 👍1
andykog commented

Done, see hodorswit/react-mobx-realworld-example-app
Replaced redux with mobx, added/modified a few components here and there. Used singletone stores for simplicity.

  • 👍2
  • ❤️2
EricSimons commented

Woot! Can one of the MobX folks here take a peek at @andykog's codebase and provide feedback (and/or approve it)? 💪

mweststrate commented

@EricSimons will try to check later today / tomorrow

  • 👍1
  • ❤️1
mweststrate commented

@andykog wot that was quite an endeavour! looking good and idiomatic!

Didn't check all the components, but a small thing I noticed in the stores: ArticleStore has both articles and articlesRegistery. Could articles be expressed as @computed get articles() { return this.articlesRegistery.values() }?

andykog commented

@mweststrate, I think arrays are generally better suited for managing order, but in our case you proposition should work great. Thanks for the review!

andykog commented

(done)

EricSimons commented

@andykog @hodorswit just added you both to the 'offical' repo — also have react-mobx.realworld.io pointed to github pages, so feel free to set up GH pages branch and it will show up live at that URL :)

EricSimons commented

Just added the repo to the main README btw — amazing work guys! 👍 💯

Lmk when you have the GH pages set up & I'll close out this issue

robbiedhickey commented

@EricSimons The demo is running via gh-pages at the following URL https://gothinkster.github.io/react-mobx-realworld-example-app 👍

For some reason the https://react-mobx.realworld.io URL is 404'ing. Is it worthwhile to troubleshoot this or do you think the default gh-pages link is fine?