🗄🔧 Slim
silentworks opened this issue · 17 comments
Current Status
-
Codebase in progress:
alhoqbani/realworld-slim -
Interested in helping out? Say hello! 🎉
gitter.im/realworld-dev/php-slim
Todo:
- 🏁 Fork the starter repo & post the link in this issue
- 🎨 Create logo for repo & update issue status (@EricSimons)
- 🔨 Implement all of Conduit's functionality per the spec & API
- 👀 Move repo to main org & Peer review final codebase by admins/community (RFC)
- 🎉 Tag v1 release and officially list it on the README!
Awesome! Just updated the issue status, created a gitter room for us to manage collaborator coordination, and created the logo for your repo's readme 👍:
@silentworks FYI some folks in the Gitter channel (https://gitter.im/realworld-dev/php-slim) are asking q's regarding what the DB layer will be, etc
As I won't have the time, I am transferring this project over to @railto, will change the codebase link above to match this also.
Hi guys, are you are still working on this? I would like to build the app.
@alhoqbani yes this is something we will be working on
I finished the app. Here is a live demo: https://slim-realworld.herokuapp.com/api/articles
And here is another demo with angular as a frontend linked with the slim as backend https://angular-realworld.herokuapp.com
Should I make a separate issue proposing my codebase? @EricSimons
@SandeeshS would have time to take a look at this from a code review point of view? I glanced through it and it looked fine but it's been a while since I did any php.
@alhoqbani My only feedback would be to add some more info to the README. Assume someone has never used the Slim framework. Other than composer install are there any relevant notes? How do you run tests, what is significance of the architecture and directory structure, etc. I think @SandeeshS Laravel repo is a great example of adding plenty of information to the README.
Other than that I think this is ready for listing on the README. 🎉
I decided to wait for the peer-review before writing the README, just in case there is any comments on the structure of the code.
However, I will prepare more detailed on the architecture and directory structure in the README soon.
I have reviewed the code @alhoqbani provided and it is definitely the approach I would have taken. I think it shows off quite a few of the features that Slim provide.
I have changed the codebase link above to match @alhoqbani repo as I think it should be used as the official submission. Thanks for deciding to this @alhoqbani, I am happy that someone else was able to complete this as most of us on the team have gotten real busy lately.
Hat tip to you @alhoqbani
Thanks @silentworks, glad to hear that from you.
Excellent, excellent work @alhoqbani. That readme especially is so thorough & incredibly well done! Also, @silentworks thanks so much for chiming in here with your expertise and insight! It's seriously such an honor to have amazing folks like y'all helping push the RealWorld project forward. Thanks so much. ❤️
I've gone ahead and spun up the official repo (https://github.com/gothinkster/slim-php-realworld-example-app) and will be listing it on the homepage shortly! 🎉
Again, amazing work y'all!!
Thanks @EricSimons, although I'm not done with the README yet. It still needs some editing, and I was hoping someone from the Slim community could review it as well.
@alhoqbani no sweat! We can just push any updates req'd to the new repo :) Btw, do you know anyone in the Slim community I could ping about coming in to help review? Or perhaps @silentworks could review the new stuff in the readme? Lmk!
unfortunately, I 'don't know any one :(
Yes I will review it. I am from the Slim community.