gotthardp/rabbitmq-email

Unable to send mail

a-marcellini opened this issue · 2 comments

You are syncing the dev. version of gen_smtp, however in the readme you declare the dependency to the 1.1.1.
What's more I'm not sure if your code acknowledges the mimemail encode modification: from list to map.
here the code

I'm not an erlang expert, however, I think that the code doesn't use maps as parameter but it uses lists:

Look at rabbit_email_sender.erl row 22 as an example, 4th parameter:
Message = mimemail:encode({Type, Subtype, lists:foldr(fun set_header/2, [], Headers2), [], Payload}),

I succesfully tested the following fix:
Message = mimemail:encode({Type, Subtype, lists:foldr(fun set_header/2, [], Headers2), #{}, Payload}),

I'm going to create a branch and a pull request.

I misread the gen_smtp code, sigh. I'll get this fixed.

Fixed in a345674