Generation conflict with Galacticraft
Closed this issue · 3 comments
Not pointing a finger here, necessarily, but the crash report is pretty clear that there's something not playing nicely between this and GC. I can't verify that there have been instances where generation has occurred successfully because I don't know what might be broken, but I have seen this exact crash 7-8 times this morning and it is resolved by removing either Dungeons2 or Galacticraft. Note that this is a pregen process for DIM0, not a GC dimension.
Posted on GC tracker as well: micdoodle8/Galacticraft#3200
MicdoodleCore-1.12.2-4.0.1.139
GalacticraftCore-1.12.2-4.0.1.139
GottschCore-mc1.12.2-f14.23.1.2555-v1.2.0
Dungeons2-mc1.12.2-f14.23.1.2555-v1.3.2
forge-1.12.2-14.23.2.2619-universal
at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:240)
at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
at micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(TransformerHooks.java:183)
at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1016)
at net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:977)
at pregenerator.impl.processor.ChunkFile.populate(ChunkFile.java:86)
at pregenerator.impl.processor.ChunkFile$ChunkFileEntry.process(ChunkFile.java:250)
at pregenerator.impl.processor.ChunkProcessor.onServerTickEvent(ChunkProcessor.java:97)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_381_ChunkProcessor_onServerTickEvent_ServerTickEvent.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
at net.minecraftforge.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:265)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:710)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
at java.lang.Thread.run(Unknown Source)
Hi, Galacticraft dev here.
As I have posted on micdoodle8/Galacticraft#3200, this issue is not being caused by Galacticraft, our code is just a hook which is passing on the Forge generate call, without any alteration at all.
So, we hook into the Minecraft chunk generator calling GameRegistry.generateWorld() and either we pass that method call on to Forge with unchanged parameters, or - if it's on a space dimension - we block it completely. Here, we passed it on, because it is chunk generation on the Overworld.
This is not a Galacticraft issue.
Seems to be biome related somehow? Looks like a duplicate of #9. Issue #9 does not have Galacticraft in the mod list.
@Teibidh you should state:
- all your other mods
- Sponge or no Sponge
- post the full log
Not able to close on my own, feel free.