govau/design-system-components

Scaffold build process fails on Windows machine

mrrossmullen opened this issue · 1 comments

Bug Report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Running npm run scaffolding on a Windows machine causes the component scaffold build process to fail.

What I expected to happen

A component is created within the packages/ directory and no errors displayed.

Reproducing

  • OS: Windows 10
  • Module name: helper.js
  • Module version: n/a
  • Pancake version: n/a
  • Node version: 14.15.4
  • npm version: 6.14.10
  • Pancake settings in your package.json:

Steps to reproduce:

  1. npm i
  2. npm run scaffolding

Attachments

Error is due to how Windows directory structure is created, the problem does not exist on Apple/Linux OS. The starting forward slash character / causes the build to fail.

image

Fixed with merged PR #1004