Table numbers font is not as expected (system SF)

Question

Table numbers font is not as expected (system SF)

sirleech opened this issue 6 years ago · 6 comments

sirleech commented 6 years ago

Bug Report

[x ] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
[ x] I’ve read and agree to the Code of Conduct.
[x ] I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Table numbers font seems to be Verdana, not the system font as expected.

What I expected to happen

On a mac, I expect this to be the SF system font. It looks a bit broken being in Verdana.

Reproducing

Latest, as on the documentation page

Attachments

Answer 1 · 2019-05-27T23:11:05.000Z

@sirleech yeah we are still trying to figure this out. If we used the default numeric (monospace) family it would look like this, which I thought looked a bit odd.

I was looking for a web safe font that has monospacing for numbers, but not other characters such as commas, decimals etc. I came across Verdana and it looked okay. But I think it makes sense to revert back to our monospace font family.

What are your thoughts?

Answer 2 · 2019-05-27T23:55:05.000Z

Makes sense Raj— this should not be a bug then as it was deliberate, feel free to close.

…

Sent from my iPad

On 28 May 2019, at 9:11 am, Raj ***@***.***> wrote: @sirleech yeah we are still trying to figure this out. If we used the default numeric (monospace) family it would look like this, which I thought looked a bit odd. I was looking for a web safe font that has monospacing for numbers, but not other characters such as commas, decimals etc. I came across Verdana and it looked okay. But I think it makes sense to revert back to our monospace font family. What are your thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 3 · 2019-05-28T00:05:08.000Z

@sirleech I'll leave it open for now, in case anybody has an elegant solution to this problem.

Answer 4 · 2019-05-28T00:42:25.000Z

This seems to work ok:
font-variant-numeric: tabular-nums;

from:
https://blog.usejournal.com/proportional-vs-monospaced-numbers-when-to-use-which-one-in-order-to-avoid-wiggling-labels-e31b1c83e4d0

Answer 5 · 2019-05-28T01:30:11.000Z

@sirleech I think you are onto something, let me give this a whirl 👍

Answer 6 · 2019-05-28T01:45:43.000Z

okay cool so font-variant-numeric is not supported on older browsers...but I can use font-variant and apply this property to the .au-table__cell--numeric class. Thanks Chris!