Images on card overflow the border radius
petrillek opened this issue · 1 comments
petrillek commented
Bug Report
- I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
- I’ve read and agree to the Code of Conduct.
- I’ve searched for any related issues and avoided creating a duplicate issue.
What happened
Images in basic Cards (no shadow) are overlapping over the border radius.
What I expected to happen
Images should follow the same border radius.
Reproducing
- Module name: Card
- Module version: 0.3.1
- Pancake version: 1.4.1
- Node version: 8.15.1
- npm version: 6.5.0
- Pancake settings in your
package.json
: Not related to the issue.
Steps to reproduce:
- Go to https://designsystem.gov.au/components/card/#images
- Compare with https://designsystem.gov.au/components/card/#images
- Clickable Card has a class
au-card--shadow
which is setting property overflow: hidden; This property should be directly on theau-card
class, so it will work on images even without shadow.
Attachments
Styling was changed in the browser to better show the problem (bigger border raidus, different border color).
sukhrajghuman commented
@petrillek really nice pickup. Will correct it shortly