gpbl/isomorphic500

Changes to Intl message aren't picked up by hot-loader

paul-sachs opened this issue · 3 comments

paul-sachs commented

Any changes I make to en.js / it.js or any other localization file aren't picked up until I restart. Anyone know anyway to make the localization hot-loadable?

gpbl commented

Hi @psachs21 yup that's true! Nice catch.

I remember I was playing with the idea and I got it working, but it didn't make it into this project. It should be possibile by signing each file (en.js) with module.hot. Need to investigate and re-read the docs a bit ...

paul-sachs commented

Alright cool, I'll take a look at that and see what I can do. Potential pull request perhaps. Thanks.

paul-sachs commented

Hey @gpbl, I'm having trouble seeing where I can integrate hot loading into globalization. I've only really just started looking at nodejs in general and react even more recently. When you say "signing" each file, I thought maybe adding following was enough:

if(module.hot) {
module.hot.accept();
}

But I suspect that I have to do something on the code that loads these files for it to be accepted and I'm not sure where I start there. Could you provide any pointers?