gpspake/grunterie

inline-link class in footer nav being applied to wrong element

Closed this issue · 5 comments

Not sure if this is something upstream in Reverie or not, but in footer.php we have:

wp_nav_menu(array(
'theme_location' => 'utility', 
container' => false, 
'menu_class' => 'inline-link')
);

Which seems correct.

But the inline-link class is being applied to the containing div rather than the menu's ul element.

I'll admit, don't ever use that utility nav so I haven't noticed this; it came from reverie.

That's, strange though because the reference page for wp_nav_menu says that 'menu_class' is applied to the ul while 'container_class' is applied to the div.

Also, at first glance it doesn't look like inline-link is a foundation class; It may be left over from an older version but I think that's probably intended to be Inline-list (Of course, it would need to be applied to the ul instead of the div.)

I'm planning to put up a demo site soon and fix a few other quirks in the process, so I'll make sure to check this out.

Finally got a chance to look at this; Where are you seeing inline-link?
I checked footer.php all the way back to the 5.2 update and it's inline-list.

wp_nav_menu(array(
'theme_location' => 'utility', 
'container' => false, 
'menu_class' => 'inline-list')
);

So It seems to be working for me. See it in action here

Firstly, sorry for the confusion. I actually meant inline-list, not inline-link (inline-link was used in previous versions of Foundation.

Secondly, I'm still seeing the issue - even on a default install of grunterie which I just cloned:

screen shot 2014-09-17 at 2 33 26 pm

Hmm, that is strange, that's not happening on the demo site (Which is using the current version of Grunterie.) I wonder if it could be a child theme issue or something?
Could you share your footer.php and a link to the site?

OK, worked it out.

If you don't have an menu assigned to the 'Utility' location, then the HTML output is as above.

Once you assign a menu to the 'Utility' location, then all is fine.