CircleCI doesn't not build for Forked PRs
hdost opened this issue · 3 comments
@Dieterbe so I know we've mostely been communicating about this in the PRs #406 #407
I think it might be good to just have it in an issue. What we know:
- Setting for forked PRs is Turned on.
- PRs from forked Repositories not building.
I have performed a couple of tests on https://github.com/hdost/goran I created a fork in to criteo-forks I even had someone else in my team create a PR with a random change to it. I had set an environment variable in the project before creating any PRs.
- My PRs from a forked repo are building
- His PRs from a forked repo are building build
** I also asked him to create his own fork of the repo, and it still starts building.
Two possibilities that I can think of:
- There is in the grafana org setup. My guess would be that maybe old style Github Services are being used instead of Github Apps. Check https://github.com/grafana/carbon-relay-ng/settings/installations and possible re-configure it, even with the same settings.
- Unless you're using the variable somewhere in the repo it doesn't do restrictions. (Not sure how they would determine this.)
There is in the grafana org setup. My guess would be that maybe old style Github Services are being used instead of Github Apps. Check https://github.com/grafana/carbon-relay-ng/settings/installations and possible re-configure it
this shows the "CircleCI Checks", no services. There's no config options there for the App, but I went back to the circleCI config, and disabled and re-enabled "Build forked pull requests", and also enabled "GitHub Status updates" which was previously off.
"Pass secrets to builds from forked pull requests" is off (of course).
this option is also on:
"Only build pull requests
By default, we will build all the commits for this project. Once turned on, we will only build branches that have associated pull requests open."
Let me see if i can contact support, as we have a paid account.