grafana/dashboard-linter

Error against template label when label is already defined

mshahzeb opened this issue · 2 comments

mshahzeb commented

[template-job-rule] 'Asterisk - Overview': Dashboard 'Asterisk - Overview' job template should be a labelled 'job'

If you look at the dashboard JSON file - the job temlpate already has a label.
asterisk-overview.json.zip

tomwilkie commented

Hi @mshahzeb! Thanks for filling the issue.

I've improved the error message to make it a little more obvious, but I think the failure is just in capitalisation:

[❌] Dashboard 'Asterisk - Overview' job template should be a labelled 'job', is currently 'Job'

I went with lowercase 'job' for the labels for convenience really - this was what most mixins I checked out were using.

Out of interest, is the asterix mixin on github somewhere?

mshahzeb commented

Hi @tomwilkie - Thanks for taking this up! - Yes the mixin is currently on my feature branch for jsonnet-libs.
https://github.com/grafana/jsonnet-libs/tree/shahzeb/asterisk-mixin/asterisk-mixin

  • 👍1