grafana/google-sheets-datasource

Referencing an empty cell in the query crashes the plugin.

oscarkilhed opened this issue · 0 comments

Referencing an empty cell as a range, causes the plugin backend to panic.

example: Sheet!F7 where F7 is empty

2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.707382849Z level=debug msg="github.com/grafana/google-sheets-datasource/pkg/googlesheets.(*GoogleSheets).transformSheetToDataFrame(0xc0004105e0, 0xc000274750, 0xc0002938f0, 0x12ea208, 0x1, 0xc00016f420, 0x0, 0x0, 0x0)" |  
-- | -- | --
  |   | 2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.707376149Z level=debug msg="\t/drone/src/pkg/googlesheets/googlesheets.go:258 +0x651" |  
  |   | 2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.707369134Z level=debug msg="github.com/grafana/google-sheets-datasource/pkg/googlesheets.getColumnDefinitions(0x0, 0x0, 0x0, 0xc000780000, 0x0, 0xc000b215d8, 0x41480b)" |  
  |   | 2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.70735808Z level=debug msg="goroutine 223 [running]:" |  
  |   | 2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.707348019Z level=debug msg= |  
  |   | 2022-11-28 14:18:07 | logger=plugin.grafana-googlesheets-datasource t=2022-11-28T14:18:07.707297707Z level=debug msg="panic: runtime error: index out of range [0] with length 0"