grafana/grafana-aws-sdk

Undocumented/unintentional(?) Breaking change

Closed this issue · 1 comments

sarahzinger commented

I was working with Athena and the grafana-aws-sdk locally and tried to upgrade and noticed that when I upgrade from 0.20 to 0.21 I get a lot of build errors, as the interfaces have changed for many methods now I think?

for example we went from
func (*awsds.AsyncAWSDatasource).NewDatasource(settings backend.DataSourceInstanceSettings)
to
func (*awsds.AsyncAWSDatasource).NewDatasource(ctx context.Context, settings backend.DataSourceInstanceSettings)

I think we are the only folks using this but we should respect semver if we can just in case. Not sure if its possible at this point to change the version? Or if there is a way to do this without breaking changes maybe we can fix that? If not maybe we should just make the next release a major change and note the error?

sarahzinger commented

@iwysiu informs me that this is not actually a bug because grafana-aws-sdk is still in version 0.x.x which means that we're still in the pre-release stage and there's no such thing as a breaking change which makes sense, and tbh I agree this lib is not really in a place where we can't guarantee no breaking changes yet. So closing as not planned since there's no work here haha. Upgrading Athena now to handle the breaking changes.