grafana/plugin-tools

Bug: package eslint-config should be upgraded to ^7.0.0

briangann opened this issue · 0 comments

Which package(s) does this bug affect?

  • Create Plugin
  • Sign Plugin
  • Plugin E2E

Package versions

4.2.0

What happened?

when updating polystat to latest, the eslint-config package was left at v6, which is not compatible with node 20 (jsdoc is pulled in and triggers this error)

What you expected to happen

updating plugin and using node20 should work

How to reproduce it (as minimally and precisely as possible)

Clone grafana-polystat-panel main and with node v20, run

npx @grafana/create-plugin@latest update

yarn install will fail

Environment

❯ npx envinfo --system --binaries --browsers --npmPackages="@grafana/*"

  System:
    OS: macOS 14.3
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 22.67 GB / 96.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.volta/tools/image/node/20.11.0/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/4.1.0/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/20.11.0/bin/npm
    pnpm: 8.15.3 - ~/.volta/bin/pnpm
  Browsers:
    Brave Browser: 121.1.62.165
    Chrome: 121.0.6167.184
    Safari: 17.3
  npmPackages:
    @grafana/data: 8.4.11 => 8.4.11
    @grafana/e2e: 10.3.3 => 10.3.3
    @grafana/e2e-selectors: 10.3.3 => 10.3.3
    @grafana/eslint-config: ^7.0.0 => 7.0.0
    @grafana/runtime: 8.4.11 => 8.4.11
    @grafana/schema: 10.3.3 => 10.3.3
    @grafana/tsconfig: ^1.3.0-rc1 => 1.3.0-rc1
    @grafana/ui: 8.4.11 => 8.4.11

Additional context

manually updating devDependencies to this fixes the issue:

    "@grafana/eslint-config": "^7.0.0",